-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose secret as SecretReader and InlineSecret from config package #650
Conversation
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I checked and we don't have SecretReader
nor InlineSecret
in Prometheus so the names LGTM.
@SuperQ @ArthurSens any objections? |
I'm going to proceed with the merge as exposing things public is most of the time uncontroversial, but do let me know if there's anything that needs addressing. I've checked Prometheus and the Alertmanger - and these aren't conflicting. |
Nice! this was also breaking Thanos: #538 (comment) |
Actually thanos also need the FileSecret to be exposed: =/ |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.54.0` -> `v0.55.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.54.0/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.54.0/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.55.0`](https://github.com/prometheus/common/releases/tag/v0.55.0) [Compare Source](https://github.com/prometheus/common/compare/v0.54.0...v0.55.0) #### What's Changed - Update Go modules by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#643 - enable errcheck linter by [@​mmorel-35](https://github.com/mmorel-35) in [prometheus/common#637 - Add a `RELEASE.md` and add [@​gotjosh](https://github.com/gotjosh) as a mantainer by [@​gotjosh](https://github.com/gotjosh) in [prometheus/common#644 - Move goautoneg to external dependency by [@​mikelolasagasti](https://github.com/mikelolasagasti) in [prometheus/common#625 - Expose secret as SecretReader and InlineSecret from config package by [@​pracucci](https://github.com/pracucci) in [prometheus/common#650 - Fix HTTPClientConfig JSON marshalling by [@​pracucci](https://github.com/pracucci) in [prometheus/common#651 - Expose secret as FileSecret from config package by [@​alanprot](https://github.com/alanprot) in [prometheus/common#653 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#646 - Set http_headers to be omit empty by [@​yeya24](https://github.com/yeya24) in [prometheus/common#655 - chore: add HumanizeTimestamp; make ConvertToFloat exportable by [@​freak12techno](https://github.com/freak12techno) in [prometheus/common#654 - Bump github.com/aws/aws-sdk-go from 1.53.14 to 1.54.7 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#659 - Bump golang.org/x/oauth2 from 0.20.0 to 0.21.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#656 - Bump google.golang.org/protobuf from 1.34.1 to 1.34.2 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#658 - Bump golang.org/x/net from 0.25.0 to 0.26.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#657 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#660 - Add SigV4 FIPS STS endpoint config by [@​rajagopalanand](https://github.com/rajagopalanand) in [prometheus/common#649 #### New Contributors - [@​gotjosh](https://github.com/gotjosh) made their first contribution in [prometheus/common#644 - [@​mikelolasagasti](https://github.com/mikelolasagasti) made their first contribution in [prometheus/common#625 - [@​alanprot](https://github.com/alanprot) made their first contribution in [prometheus/common#653 - [@​yeya24](https://github.com/yeya24) made their first contribution in [prometheus/common#655 - [@​rajagopalanand](https://github.com/rajagopalanand) made their first contribution in [prometheus/common#649 **Full Changelog**: prometheus/common@v0.54.0...v0.55.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jaegertracing/jaeger). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJjaGFuZ2Vsb2c6ZGVwZW5kZW5jaWVzIl19--> --------- Signed-off-by: Mend Renovate <bot@renovateapp.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Yuri Shkuro <github@ysh.us>
…5806) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.54.0` -> `v0.55.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.54.0/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.54.0/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.55.0`](https://github.com/prometheus/common/releases/tag/v0.55.0) [Compare Source](https://github.com/prometheus/common/compare/v0.54.0...v0.55.0) #### What's Changed - Update Go modules by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#643 - enable errcheck linter by [@​mmorel-35](https://github.com/mmorel-35) in [prometheus/common#637 - Add a `RELEASE.md` and add [@​gotjosh](https://github.com/gotjosh) as a mantainer by [@​gotjosh](https://github.com/gotjosh) in [prometheus/common#644 - Move goautoneg to external dependency by [@​mikelolasagasti](https://github.com/mikelolasagasti) in [prometheus/common#625 - Expose secret as SecretReader and InlineSecret from config package by [@​pracucci](https://github.com/pracucci) in [prometheus/common#650 - Fix HTTPClientConfig JSON marshalling by [@​pracucci](https://github.com/pracucci) in [prometheus/common#651 - Expose secret as FileSecret from config package by [@​alanprot](https://github.com/alanprot) in [prometheus/common#653 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#646 - Set http_headers to be omit empty by [@​yeya24](https://github.com/yeya24) in [prometheus/common#655 - chore: add HumanizeTimestamp; make ConvertToFloat exportable by [@​freak12techno](https://github.com/freak12techno) in [prometheus/common#654 - Bump github.com/aws/aws-sdk-go from 1.53.14 to 1.54.7 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#659 - Bump golang.org/x/oauth2 from 0.20.0 to 0.21.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#656 - Bump google.golang.org/protobuf from 1.34.1 to 1.34.2 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#658 - Bump golang.org/x/net from 0.25.0 to 0.26.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#657 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#660 - Add SigV4 FIPS STS endpoint config by [@​rajagopalanand](https://github.com/rajagopalanand) in [prometheus/common#649 #### New Contributors - [@​gotjosh](https://github.com/gotjosh) made their first contribution in [prometheus/common#644 - [@​mikelolasagasti](https://github.com/mikelolasagasti) made their first contribution in [prometheus/common#625 - [@​alanprot](https://github.com/alanprot) made their first contribution in [prometheus/common#653 - [@​yeya24](https://github.com/yeya24) made their first contribution in [prometheus/common#655 - [@​rajagopalanand](https://github.com/rajagopalanand) made their first contribution in [prometheus/common#649 **Full Changelog**: prometheus/common@v0.54.0...v0.55.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-go-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJTa2lwIENoYW5nZWxvZyIsImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…5552) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.54.0` -> `v0.55.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.54.0/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.54.0/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.55.0`](https://github.com/prometheus/common/releases/tag/v0.55.0) [Compare Source](https://github.com/prometheus/common/compare/v0.54.0...v0.55.0) #### What's Changed - Update Go modules by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#643 - enable errcheck linter by [@​mmorel-35](https://github.com/mmorel-35) in [prometheus/common#637 - Add a `RELEASE.md` and add [@​gotjosh](https://github.com/gotjosh) as a mantainer by [@​gotjosh](https://github.com/gotjosh) in [prometheus/common#644 - Move goautoneg to external dependency by [@​mikelolasagasti](https://github.com/mikelolasagasti) in [prometheus/common#625 - Expose secret as SecretReader and InlineSecret from config package by [@​pracucci](https://github.com/pracucci) in [prometheus/common#650 - Fix HTTPClientConfig JSON marshalling by [@​pracucci](https://github.com/pracucci) in [prometheus/common#651 - Expose secret as FileSecret from config package by [@​alanprot](https://github.com/alanprot) in [prometheus/common#653 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#646 - Set http_headers to be omit empty by [@​yeya24](https://github.com/yeya24) in [prometheus/common#655 - chore: add HumanizeTimestamp; make ConvertToFloat exportable by [@​freak12techno](https://github.com/freak12techno) in [prometheus/common#654 - Bump github.com/aws/aws-sdk-go from 1.53.14 to 1.54.7 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#659 - Bump golang.org/x/oauth2 from 0.20.0 to 0.21.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#656 - Bump google.golang.org/protobuf from 1.34.1 to 1.34.2 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#658 - Bump golang.org/x/net from 0.25.0 to 0.26.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#657 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#660 - Add SigV4 FIPS STS endpoint config by [@​rajagopalanand](https://github.com/rajagopalanand) in [prometheus/common#649 #### New Contributors - [@​gotjosh](https://github.com/gotjosh) made their first contribution in [prometheus/common#644 - [@​mikelolasagasti](https://github.com/mikelolasagasti) made their first contribution in [prometheus/common#625 - [@​alanprot](https://github.com/alanprot) made their first contribution in [prometheus/common#653 - [@​yeya24](https://github.com/yeya24) made their first contribution in [prometheus/common#655 - [@​rajagopalanand](https://github.com/rajagopalanand) made their first contribution in [prometheus/common#649 **Full Changelog**: prometheus/common@v0.54.0...v0.55.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-go). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJTa2lwIENoYW5nZWxvZyIsImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.54.0` -> `v0.55.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.54.0/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.54.0/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.55.0`](https://github.com/prometheus/common/releases/tag/v0.55.0) [Compare Source](https://github.com/prometheus/common/compare/v0.54.0...v0.55.0) #### What's Changed - Update Go modules by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#643 - enable errcheck linter by [@​mmorel-35](https://github.com/mmorel-35) in [prometheus/common#637 - Add a `RELEASE.md` and add [@​gotjosh](https://github.com/gotjosh) as a mantainer by [@​gotjosh](https://github.com/gotjosh) in [prometheus/common#644 - Move goautoneg to external dependency by [@​mikelolasagasti](https://github.com/mikelolasagasti) in [prometheus/common#625 - Expose secret as SecretReader and InlineSecret from config package by [@​pracucci](https://github.com/pracucci) in [prometheus/common#650 - Fix HTTPClientConfig JSON marshalling by [@​pracucci](https://github.com/pracucci) in [prometheus/common#651 - Expose secret as FileSecret from config package by [@​alanprot](https://github.com/alanprot) in [prometheus/common#653 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#646 - Set http_headers to be omit empty by [@​yeya24](https://github.com/yeya24) in [prometheus/common#655 - chore: add HumanizeTimestamp; make ConvertToFloat exportable by [@​freak12techno](https://github.com/freak12techno) in [prometheus/common#654 - Bump github.com/aws/aws-sdk-go from 1.53.14 to 1.54.7 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#659 - Bump golang.org/x/oauth2 from 0.20.0 to 0.21.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#656 - Bump google.golang.org/protobuf from 1.34.1 to 1.34.2 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#658 - Bump golang.org/x/net from 0.25.0 to 0.26.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#657 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#660 - Add SigV4 FIPS STS endpoint config by [@​rajagopalanand](https://github.com/rajagopalanand) in [prometheus/common#649 #### New Contributors - [@​gotjosh](https://github.com/gotjosh) made their first contribution in [prometheus/common#644 - [@​mikelolasagasti](https://github.com/mikelolasagasti) made their first contribution in [prometheus/common#625 - [@​alanprot](https://github.com/alanprot) made their first contribution in [prometheus/common#653 - [@​yeya24](https://github.com/yeya24) made their first contribution in [prometheus/common#655 - [@​rajagopalanand](https://github.com/rajagopalanand) made their first contribution in [prometheus/common#649 **Full Changelog**: prometheus/common@v0.54.0...v0.55.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.54.0` -> `v0.55.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.54.0/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.54.0/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.55.0`](https://github.com/prometheus/common/releases/tag/v0.55.0) [Compare Source](https://github.com/prometheus/common/compare/v0.54.0...v0.55.0) ##### What's Changed - Update Go modules by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#643 - enable errcheck linter by [@​mmorel-35](https://github.com/mmorel-35) in [prometheus/common#637 - Add a `RELEASE.md` and add [@​gotjosh](https://github.com/gotjosh) as a mantainer by [@​gotjosh](https://github.com/gotjosh) in [prometheus/common#644 - Move goautoneg to external dependency by [@​mikelolasagasti](https://github.com/mikelolasagasti) in [prometheus/common#625 - Expose secret as SecretReader and InlineSecret from config package by [@​pracucci](https://github.com/pracucci) in [prometheus/common#650 - Fix HTTPClientConfig JSON marshalling by [@​pracucci](https://github.com/pracucci) in [prometheus/common#651 - Expose secret as FileSecret from config package by [@​alanprot](https://github.com/alanprot) in [prometheus/common#653 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#646 - Set http_headers to be omit empty by [@​yeya24](https://github.com/yeya24) in [prometheus/common#655 - chore: add HumanizeTimestamp; make ConvertToFloat exportable by [@​freak12techno](https://github.com/freak12techno) in [prometheus/common#654 - Bump github.com/aws/aws-sdk-go from 1.53.14 to 1.54.7 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#659 - Bump golang.org/x/oauth2 from 0.20.0 to 0.21.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#656 - Bump google.golang.org/protobuf from 1.34.1 to 1.34.2 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#658 - Bump golang.org/x/net from 0.25.0 to 0.26.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#657 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#660 - Add SigV4 FIPS STS endpoint config by [@​rajagopalanand](https://github.com/rajagopalanand) in [prometheus/common#649 ##### New Contributors - [@​gotjosh](https://github.com/gotjosh) made their first contribution in [prometheus/common#644 - [@​mikelolasagasti](https://github.com/mikelolasagasti) made their first contribution in [prometheus/common#625 - [@​alanprot](https://github.com/alanprot) made their first contribution in [prometheus/common#653 - [@​yeya24](https://github.com/yeya24) made their first contribution in [prometheus/common#655 - [@​rajagopalanand](https://github.com/rajagopalanand) made their first contribution in [prometheus/common#649 **Full Changelog**: prometheus/common@v0.54.0...v0.55.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
…#33852) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.54.0` -> `v0.55.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.54.0/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.54.0/v0.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.55.0`](https://github.com/prometheus/common/releases/tag/v0.55.0) [Compare Source](https://github.com/prometheus/common/compare/v0.54.0...v0.55.0) #### What's Changed - Update Go modules by [@&open-telemetry#8203;SuperQ](https://github.com/SuperQ) in [prometheus/common#643 - enable errcheck linter by [@&open-telemetry#8203;mmorel-35](https://github.com/mmorel-35) in [prometheus/common#637 - Add a `RELEASE.md` and add [@&open-telemetry#8203;gotjosh](https://github.com/gotjosh) as a mantainer by [@&open-telemetry#8203;gotjosh](https://github.com/gotjosh) in [prometheus/common#644 - Move goautoneg to external dependency by [@&open-telemetry#8203;mikelolasagasti](https://github.com/mikelolasagasti) in [prometheus/common#625 - Expose secret as SecretReader and InlineSecret from config package by [@&open-telemetry#8203;pracucci](https://github.com/pracucci) in [prometheus/common#650 - Fix HTTPClientConfig JSON marshalling by [@&open-telemetry#8203;pracucci](https://github.com/pracucci) in [prometheus/common#651 - Expose secret as FileSecret from config package by [@&open-telemetry#8203;alanprot](https://github.com/alanprot) in [prometheus/common#653 - Synchronize common files from prometheus/prometheus by [@&open-telemetry#8203;prombot](https://github.com/prombot) in [prometheus/common#646 - Set http_headers to be omit empty by [@&open-telemetry#8203;yeya24](https://github.com/yeya24) in [prometheus/common#655 - chore: add HumanizeTimestamp; make ConvertToFloat exportable by [@&open-telemetry#8203;freak12techno](https://github.com/freak12techno) in [prometheus/common#654 - Bump github.com/aws/aws-sdk-go from 1.53.14 to 1.54.7 in /sigv4 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#659 - Bump golang.org/x/oauth2 from 0.20.0 to 0.21.0 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#656 - Bump google.golang.org/protobuf from 1.34.1 to 1.34.2 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#658 - Bump golang.org/x/net from 0.25.0 to 0.26.0 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#657 - Synchronize common files from prometheus/prometheus by [@&open-telemetry#8203;prombot](https://github.com/prombot) in [prometheus/common#660 - Add SigV4 FIPS STS endpoint config by [@&open-telemetry#8203;rajagopalanand](https://github.com/rajagopalanand) in [prometheus/common#649 #### New Contributors - [@&open-telemetry#8203;gotjosh](https://github.com/gotjosh) made their first contribution in [prometheus/common#644 - [@&open-telemetry#8203;mikelolasagasti](https://github.com/mikelolasagasti) made their first contribution in [prometheus/common#625 - [@&open-telemetry#8203;alanprot](https://github.com/alanprot) made their first contribution in [prometheus/common#653 - [@&open-telemetry#8203;yeya24](https://github.com/yeya24) made their first contribution in [prometheus/common#655 - [@&open-telemetry#8203;rajagopalanand](https://github.com/rajagopalanand) made their first contribution in [prometheus/common#649 **Full Changelog**: prometheus/common@v0.54.0...v0.55.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Thanks for fixing! |
#572 broke the vendoring in Mimir, where we have an use case calling
NewBasicAuthRoundTripper()
. The problem is that thesecret
interface is private, but it's used in publicly exposed functions likeNewBasicAuthRoundTripper()
.In this PR I propose to expose
secret
asSecretReader
(we already havetype Secret string
) and to also exposeInlineSecret
given passing a const secret is a common use case.